[PM-5691] Extract crypto to separate crate #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No New Or Fixed Issues Found |
# Conflicts: # crates/bitwarden-crypto/src/enc_string.rs # crates/bitwarden-crypto/src/rsa.rs # crates/bitwarden/Cargo.toml # crates/bitwarden/src/auth/login/access_token.rs # crates/bitwarden/src/auth/login/api_key.rs # crates/bitwarden/src/auth/login/password.rs # crates/bitwarden/src/client/client.rs # crates/bitwarden/src/client/encryption_settings.rs # crates/bitwarden/src/crypto/enc_string.rs # crates/bitwarden/src/crypto/enc_string/symmetric.rs # crates/bitwarden/src/crypto/mod.rs # crates/bitwarden/src/mobile/crypto.rs # crates/bitwarden/src/tool/generators/client_generator.rs # crates/bitwarden/src/tool/generators/passphrase.rs # crates/bitwarden/src/uniffi_support.rs # crates/bitwarden/src/vault/cipher/attachment.rs # crates/bitwarden/src/vault/cipher/card.rs # crates/bitwarden/src/vault/cipher/cipher.rs # crates/bitwarden/src/vault/cipher/field.rs # crates/bitwarden/src/vault/cipher/identity.rs # crates/bitwarden/src/vault/cipher/login.rs # crates/bitwarden/src/vault/cipher/secure_note.rs # crates/bitwarden/src/vault/collection.rs # crates/bitwarden/src/vault/folder.rs # crates/bitwarden/src/vault/password_history.rs # crates/bitwarden/src/vault/send.rs
Hinton
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #402 +/- ##
==========================================
+ Coverage 50.04% 50.15% +0.10%
==========================================
Files 155 157 +2
Lines 7467 7493 +26
==========================================
+ Hits 3737 3758 +21
- Misses 3730 3735 +5 ☔ View full report in Codecov by Sentry. |
# Conflicts: # crates/bitwarden/src/platform/generate_fingerprint.rs
# Conflicts: # crates/bitwarden/src/error.rs # crates/bitwarden/src/vault/send.rs
# Conflicts: # crates/bitwarden-crypto/src/keys/symmetric_crypto_key.rs # crates/bitwarden/src/crypto/mod.rs # crates/bitwarden/src/vault/send.rs
# Conflicts: # crates/bitwarden/src/auth/password.rs
# Conflicts: # crates/bitwarden-crypto/src/enc_string/asymmetric.rs # crates/bitwarden-crypto/src/enc_string/symmetric.rs # crates/bitwarden-crypto/src/keys/master_key.rs # crates/bitwarden-crypto/src/keys/symmetric_crypto_key.rs # crates/bitwarden-crypto/src/rsa.rs # crates/bitwarden/src/auth/login/access_token.rs # crates/bitwarden/src/client/access_token.rs # crates/bitwarden/src/platform/generate_fingerprint.rs
# Conflicts: # crates/bitwarden-crypto/src/enc_string/symmetric.rs # crates/bitwarden-crypto/src/keys/master_key.rs # crates/bitwarden-crypto/src/keys/symmetric_crypto_key.rs # crates/bitwarden/src/crypto/mod.rs
# Conflicts: # crates/bitwarden-crypto/src/keys/master_key.rs # crates/bitwarden/src/crypto/mod.rs
dani-garcia
previously approved these changes
Jan 11, 2024
Hinton
changed the title
# Conflicts: # crates/bitwarden-crypto/src/asymmetric_crypto_key.rs # crates/bitwarden-crypto/src/enc_string/asymmetric.rs # crates/bitwarden-crypto/src/encryptable.rs # crates/bitwarden-crypto/src/keys/key_encryptable.rs # crates/bitwarden-crypto/src/keys/symmetric_crypto_key.rs # crates/bitwarden/src/client/encryption_settings.rs # crates/bitwarden/src/crypto/mod.rs # crates/bitwarden/src/vault/cipher/attachment.rs # crates/bitwarden/src/vault/cipher/card.rs # crates/bitwarden/src/vault/cipher/cipher.rs # crates/bitwarden/src/vault/cipher/field.rs # crates/bitwarden/src/vault/cipher/identity.rs # crates/bitwarden/src/vault/cipher/local_data.rs # crates/bitwarden/src/vault/cipher/login.rs # crates/bitwarden/src/vault/cipher/secure_note.rs # crates/bitwarden/src/vault/collection.rs # crates/bitwarden/src/vault/folder.rs # crates/bitwarden/src/vault/password_history.rs # crates/bitwarden/src/vault/send.rs
dani-garcia
previously approved these changes
Jan 15, 2024
michalchecinski
requested changes
Jan 15, 2024
There was a problem hiding this comment.
There's a need to add bitwarden-crypto here: https://github.com/bitwarden/sdk/blob/1028efde6557e30d241c03fd4754d32fe38db17a/.github/workflows/version-bump.yml#L18
And also to publish workflow: https://github.com/bitwarden/sdk/blob/main/.github/workflows/publish-rust-crates.yml
michalchecinski
approved these changes
Jan 15, 2024
dani-garcia
approved these changes
Jan 15, 2024
Hinton
added a commit
that referenced
this pull request
Jan 19, 2024
Continuation on #402. This PR extracts the generators to their own crate to establish clear boundaries between the code. There is still some logic in the client to expose generators that we may want to revisit. Also extracts explicit errors for the different generators for better error handling downstream when/if desired.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
We should make an effort to break up the large
bitwardencrate into smaller more isolated crates. This extracts the cryptographic primitives into a crate, which better isolates them and may improve compile time slightly. We should continue to extract further areas.Code changes
crates/bitwarden-crypto.Screenshots
Before you submit